This repository was archived by the owner on Jan 4, 2022. It is now read-only.
Make master/worker be numbered rather than random-string for name. #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: using NodePort, its simpler to remember `kube-spawn-cluster-worker-1` than to do a machinectl and find the machine name which was used. The former is invariant across invocations.
Member
|
Hmm, I'm not sure about this. |
Contributor
Author
|
the names are still unique.
kube-spawn-<CLUSTER>-<master|worker>-#
and # is incrementing.
it just allows me to always refer to a worker when using NodePort to come
into it, rather than run machinectl to find the IP.
…On Thu, 30 Aug 2018 at 10:08, Dongsu Park ***@***.***> wrote:
Hmm, I'm not sure about this.
I agree that it would be simpler to remember with human-readable strings.
That was our original behavior, until we recently took the current
approach. If we go back to the original behavior again, then we would lose
uniqueness in the names.
Let me think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#305 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE5Ok1uYBEAtoL2qdDvNaw8acXdyptkyks5uV_HsgaJpZM4WTX1V>
.
|
Contributor
Author
|
any comment on this? |
Member
|
@donbowman Sorry. This PR slipped through my fingers. How about making a command-line option for the different naming scheme, instead of changing the default one? |
Contributor
Author
|
I guess i don't understand what the random one achieves for anyone? Its no more unique. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: using NodePort, its simpler to remember
kube-spawn-cluster-worker-1than to do a machinectl and find the machine name which was used. The former is invariant across invocations.